[ 
https://issues.apache.org/jira/browse/HBASE-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023841#comment-15023841
 ] 

Matteo Bertozzi commented on HBASE-14843:
-----------------------------------------

as I said, the current code load() is sync. so you need to wait every log to be 
read. but that just because I didn't have time to finish that code. 

but we don't need to read all the logs to be able to start procedures. think 
about this case:
procedure-1 is on wal1, then we roll, procedure 2 is on wal2. both procedure 
can be start before reading the other wal, and we know already that when we 
read the log.

the code on the read side is almost there but there are other things in the wal 
and executor that needs to be done. See 
https://github.com/apache/hbase/blob/master/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/ProcedureWALFormatReader.java#L159

> TestWALProcedureStore.testLoad is flakey
> ----------------------------------------
>
>                 Key: HBASE-14843
>                 URL: https://issues.apache.org/jira/browse/HBASE-14843
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Heng Chen
>            Assignee: Matteo Bertozzi
>            Priority: Blocker
>             Fix For: 2.0.0, 1.2.0
>
>         Attachments: HBASE-14843-v0.patch
>
>
> I see it twice recently, 
> see.
> https://builds.apache.org/job/PreCommit-HBASE-Build/16589//testReport/org.apache.hadoop.hbase.procedure2.store.wal/TestWALProcedureStore/testLoad/
> https://builds.apache.org/job/PreCommit-HBASE-Build/16532/testReport/org.apache.hadoop.hbase.procedure2.store.wal/TestWALProcedureStore/testLoad/
> Let's see what's happening.
> Update.
> It failed once again today, 
> https://builds.apache.org/job/PreCommit-HBASE-Build/16602/testReport/junit/org.apache.hadoop.hbase.procedure2.store.wal/TestWALProcedureStore/testLoad/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to