[
https://issues.apache.org/jira/browse/HBASE-14891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031722#comment-15031722
]
Hadoop QA commented on HBASE-14891:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12774783/HBASE-14891.v2.patch
against master branch at commit 71d41e0c9c286b4bed9cc6d5560a14268f9b1de9.
ATTACHMENT ID: 12774783
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16698//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16698//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16698//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16698//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16698//console
This message is automatically generated.
> Add log for uncaught exception in RegionServerMetricsWrapperRunnable
> --------------------------------------------------------------------
>
> Key: HBASE-14891
> URL: https://issues.apache.org/jira/browse/HBASE-14891
> Project: HBase
> Issue Type: Improvement
> Components: metrics
> Reporter: Yu Li
> Assignee: Yu Li
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-14891.patch, HBASE-14891.v2.patch,
> HBASE-14891.v2.patch
>
>
> We are using ScheduledExecutorService#scheduleWithFixedDelay to periodically
> reporting metrics. From javadoc of this method
> {quote}
> If any execution of the task encounters an exception, subsequent executions
> are suppressed.
> {quote}
> We could see if any uncaught exception like NPE thrown in the task thread,
> there won't be any error thrown but the task would be silently terminated.
> In our real case we were making some modification to the metrics and causing
> NPE carelessly, then we found metrics disappeared but cannot get a clue from
> RS log.
> Suggest to catch Throwable in
> MetricsRegionServerWrapperImpl$RegionServerMetricsWrapperRunnable, add some
> log there and suppress the exception to give it another try at next scheduled
> run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
