[ 
https://issues.apache.org/jira/browse/HBASE-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036213#comment-15036213
 ] 

Ted Yu commented on HBASE-14905:
--------------------------------

nit:
The log message below should be consistent with the other messages - 'number of 
versions set to'
{code}
284           LOG.info("Version set to " + versions);
{code}
Can the regression test be part of the patch ?

> VerifyReplication does not honour versions option
> -------------------------------------------------
>
>                 Key: HBASE-14905
>                 URL: https://issues.apache.org/jira/browse/HBASE-14905
>             Project: HBase
>          Issue Type: Bug
>          Components: tooling
>    Affects Versions: 2.0.0, 0.98.16
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14905.patch, test.patch
>
>
> source:
> hbase(main):001:0> scan 't1', {RAW => true, VERSIONS => 100}
> ROW                                      COLUMN+CELL                          
>                                                                               
>    
>  r1                                      column=f1:, timestamp=1449030102091, 
> value=value1112                                                               
>    
>  r1                                      column=f1:, timestamp=1449029774173, 
> value=value1001                                                               
>    
>  r1                                      column=f1:, timestamp=1449029709974, 
> value=value1002                                                               
>    
> target:
> hbase(main):023:0> scan 't1', {RAW => true, VERSIONS => 100}
> ROW                                      COLUMN+CELL                          
>                                                                               
>    
>  r1                                      column=f1:, timestamp=1449030102091, 
> value=value1112                                                               
>    
>  r1                                      column=f1:, timestamp=1449030090758, 
> value=value1112                                                               
>    
>  r1                                      column=f1:, timestamp=1449029984282, 
> value=value1111                                                               
>    
>  r1                                      column=f1:, timestamp=1449029774173, 
> value=value1001                                                               
>    
>  r1                                      column=f1:, timestamp=1449029709974, 
> value=value1002   
> /bin/hbase org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication 
> --versions=100 1 t1
> org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication$Verifier$Counters
>               GOODROWS=1
> Does not show any mismatch. Ideally it should show. This is because in 
> VerifyReplication Class maxVersion is not correctly set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to