[
https://issues.apache.org/jira/browse/HBASE-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042064#comment-15042064
]
Hadoop QA commented on HBASE-14901:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12775827/HBASE-14901.5.patch
against master branch at commit 03e4712f0ca08d57586b3fc4d93cf02c999515d8.
ATTACHMENT ID: 12775827
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16767//console
This message is automatically generated.
> There is duplicated code to create/manage encryption keys
> ---------------------------------------------------------
>
> Key: HBASE-14901
> URL: https://issues.apache.org/jira/browse/HBASE-14901
> Project: HBase
> Issue Type: Bug
> Components: encryption
> Affects Versions: 2.0.0
> Reporter: Nate Edel
> Assignee: Nate Edel
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-14901.1.patch, HBASE-14901.2.patch,
> HBASE-14901.3.patch, HBASE-14901.5.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code
> just refactoring.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
