[
https://issues.apache.org/jira/browse/HBASE-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15043401#comment-15043401
]
Appy commented on HBASE-14916:
------------------------------
So when I was patched in v3 locally, i used 'git am' which created the file
with 755.
But then the QA on v3 failed with same permission issue. Looking at console
output, I see that the script uses `patch -p1` instead. Trying it locally, it
indeed creates new file with 644. Looking at `man patch`, there is caveat about
permissions. So I don't know how to get around that. We definitely don't want
to change `patch -1` to `git am`.
I believe file permissions are one off cases. One simple thing to do would be,
using `git am` and run test-patch.sh locally to test the checkstyle part
manually (since QA output for other tests is fine). And before finally pushing
to repo, verify permission manually.
> Add checkstyle_report.py to other branches
> ------------------------------------------
>
> Key: HBASE-14916
> URL: https://issues.apache.org/jira/browse/HBASE-14916
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-14916-branch-1-v2.patch,
> HBASE-14916-branch-1-v3.patch, HBASE-14916-branch-1.patch
>
>
> Given test-patch.sh is always run from master, and that it now uses
> checkstyle_report.py, we should pull back the script to other branches too.
> Otherwise we see error like:
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/jenkins.build/dev-support/test-patch.sh:
> line 662:
> /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase/dev-support/checkstyle_report.py:
> No such file or directory
> [reference|https://builds.apache.org/job/PreCommit-HBASE-Build/16734//consoleFull]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
