[ 
https://issues.apache.org/jira/browse/HBASE-14795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047779#comment-15047779
 ] 

Ted Malaska commented on HBASE-14795:
-------------------------------------

OK finished my review.  Please review my review, it seems to me that there is 
still failure paths where closing tables or scanner doesn't take place.  
Leaving open tables and scanners on long lived executors. 

There is also a question about thread safety and a question about implicit 
methods that don't seem to be called.

If you get a patch in tomorrow I can review tomorrow night.



> Enhance the spark-hbase scan operations
> ---------------------------------------
>
>                 Key: HBASE-14795
>                 URL: https://issues.apache.org/jira/browse/HBASE-14795
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Malaska
>            Assignee: Zhan Zhang
>            Priority: Minor
>         Attachments: 
> 0001-HBASE-14795-Enhance-the-spark-hbase-scan-operations.patch, 
> HBASE-14795-1.patch, HBASE-14795-2.patch
>
>
> This is a sub-jira of HBASE-14789.  This jira is to focus on the replacement 
> of TableInputFormat for a more custom scan implementation that will make the 
> following use case more effective.
> Use case:
> In the case you have multiple scan ranges on a single table with in a single 
> query.  TableInputFormat will scan the the outer range of the scan start and 
> end range where this implementation can be more pointed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to