[ 
https://issues.apache.org/jira/browse/HBASE-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048099#comment-15048099
 ] 

stack commented on HBASE-14946:
-------------------------------

On commit change name of this method:

    public void incrementCellSize(long cellSize) {

to incrementResponseCellSize

It is not important that it be accurate?

private long responseCellSize = 0;

Volatile? Or it don't matter? Or one thread only?

Add size to the message:

          throw new HBaseIOException("Response size would be too large");

So, we are going to break the client response?  How do they get the full 
response back?  Needs admin intervention?

Why does the scanner chunking not help here?



> Don't allow multi's to over run the max result size.
> ----------------------------------------------------
>
>                 Key: HBASE-14946
>                 URL: https://issues.apache.org/jira/browse/HBASE-14946
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.2.0, 1.3.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Critical
>         Attachments: HBASE-14946-v1.patch, HBASE-14946-v2.patch, 
> HBASE-14946-v3.patch, HBASE-14946-v5.patch, HBASE-14946.patch
>
>
> If a user puts a list of tons of different gets into a table we will then 
> send them along in a multi. The server un-wraps each get in the multi. While 
> no single get may be over the size limit the total might be.
> We should protect the server from this. 
> We should batch up on the server side so each RPC is smaller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to