[
https://issues.apache.org/jira/browse/HBASE-10390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050258#comment-15050258
]
Hadoop QA commented on HBASE-10390:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12776699/HBASE-10390-v1.patch
against master branch at commit 9647fee3f0f196d064879afd41b9eff51d5aa036.
ATTACHMENT ID: 12776699
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
new checkstyle errors. Check build console for list of new errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ return rpcCallerFactory.<Boolean>
newCaller().callWithRetries(callable, this.operationTimeout);
+ Table table =
TEST_UTIL.createTable(TableName.valueOf("testCheckAndDeleteWithCompareOpAndComparator"),
+ boolean ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER, comparator,
CompareOp.LESS, value1, delete);
+ Table table =
TEST_UTIL.createTable(TableName.valueOf("testCheckAndPutWithCompareOpAndComparator"),
+ boolean ok = table.checkAndPut(ROW, FAMILY, QUALIFIER, comparator,
CompareOp.LESS, value1, put1);
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16822//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16822//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16822//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16822//console
This message is automatically generated.
> expose checkAndPut/Delete custom comparators thru HTable
> --------------------------------------------------------
>
> Key: HBASE-10390
> URL: https://issues.apache.org/jira/browse/HBASE-10390
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Reporter: Sergey Shelukhin
> Assignee: Vladimir Rodionov
> Fix For: 2.0.0
>
> Attachments: HBASE-10390-v1.patch
>
>
> checkAndPut/Delete appear to support custom comparators. However, thru
> HTable, there's no way to pass one, it always creates BinaryComparator from
> value. It would be good to expose the custom ones in the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
