[
https://issues.apache.org/jira/browse/HBASE-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059403#comment-15059403
]
Ted Yu commented on HBASE-14985:
--------------------------------
w.r.t. TestTimeRange.java, do we need to create a new test class ?
How about folding the new test into TestTimeRangeTracker ?
> TimeRange constructors should set allTime when appropriate
> ----------------------------------------------------------
>
> Key: HBASE-14985
> URL: https://issues.apache.org/jira/browse/HBASE-14985
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.1.2, 0.98.16.1
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Minor
> Attachments: HBASE-14985.patch
>
>
> The default TimeRange constructor creates a range from 0 to Long.MAX_VALUE
> and sets an allTime flag to true. This flag allows some performance
> optimizations when comparing or using TimeRanges.
> This flag is not set, however, if you call "new TimeRange(0L)" or "new
> TimeRange(0L, Long.MAX_VALUE)", even though both of these create a logically
> equivalent TimeRange to "new TimeRange()". Since TimeRanges are immutable and
> detecting this condition is trivial, we should set the flag automatically in
> the explicit constructors when appropriate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
