[ 
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated HBASE-14964:
--------------------------------
    Attachment: HBASE-14964-branch-1.1.patch

Thanks for working on this Nate. The way our precommit tester works, all 
patches default to working against the {{master}} branch. For fixing something 
specific to an earlier branch, like this, you should name the patch 
{{HBASE-XXXX-$\{branch}.Y.patch}}

I'm re-uploading your patch, with the target branch noted. I also took the 
chance to update the commit message to note this jira, and to include a summary 
of what the original change being backported is.


> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage 
> encryption keys
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14964
>                 URL: https://issues.apache.org/jira/browse/HBASE-14964
>             Project: HBase
>          Issue Type: Improvement
>          Components: encryption
>            Reporter: Nate Edel
>            Assignee: Nate Edel
>            Priority: Minor
>             Fix For: 1.2.0, 1.3.0
>
>         Attachments: HBASE-14964-branch-1.1.patch, HBASE-14964.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and 
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection 
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code 
> just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to