[ 
https://issues.apache.org/jira/browse/HBASE-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061575#comment-15061575
 ] 

Hadoop QA commented on HBASE-14969:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12777331/HBASE-14969.patch
  against master branch at commit 546ac1cbb379acb198b2debabbf14c878ffb8a33.
  ATTACHMENT ID: 12777331

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 26 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
new checkstyle errors. Check build console for list of new errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    return "DefaultCompactionThroughputController [maxThroughput=" + 
throughputDesc(getMaxThroughput())
+      assertTrue(regionServer.getFlushThroughputController() instanceof 
NoLimitFlushThroughputController);

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this 
patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of 
the build.

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16896//console

This message is automatically generated.

> Add throughput controller for flush
> -----------------------------------
>
>                 Key: HBASE-14969
>                 URL: https://issues.apache.org/jira/browse/HBASE-14969
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-14969.patch
>
>
> In HBASE-8329 we added a throughput controller for compaction, to avoid spike 
> caused by huge IO pressure like network/disk overflow. However, even with 
> this control on, we are still observing disk utils near 100%, and by analysis 
> we think this is caused by flush, especially when we increase the setting of 
> {{hbase.hstore.flusher.count}}
> In this JIRA, we propose to add throughput control feature for flush, as a 
> supplement of HBASE-8329 to better control IO pressure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to