[
https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062417#comment-15062417
]
Sean Busbey commented on HBASE-14989:
-------------------------------------
+1.
results checking with [Yetus' test-patch looks
good|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build-rewrite/19/console]
-1 overall
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 0s | Docker mode activated.
| +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any
| | | | new or modified tests. Please justify
| | | | why no new tests are needed for this
| | | | patch. Also please list what manual
| | | | steps were performed to verify this
| | | | patch.
| +1 | mvninstall | 4m 53s | branch-1 passed
| +1 | compile | 0m 15s | branch-1 passed with JDK v1.8.0_66
| +1 | compile | 0m 16s | branch-1 passed with JDK v1.7.0_91
| +1 | checkstyle | 0m 15s | branch-1 passed
| +1 | mvneclipse | 0m 20s | branch-1 passed
| -1 | findbugs | 0m 57s | hbase-client in branch-1 has 17 extant
| | | | Findbugs warnings.
| -1 | javadoc | 0m 16s | hbase-client in branch-1 failed with
| | | | JDK v1.8.0_66.
| +1 | javadoc | 0m 19s | branch-1 passed with JDK v1.7.0_91
| +1 | mvninstall | 0m 18s | the patch passed
| +1 | compile | 0m 13s | the patch passed with JDK v1.8.0_66
| +1 | javac | 0m 13s | the patch passed
| +1 | compile | 0m 17s | the patch passed with JDK v1.7.0_91
| +1 | javac | 0m 17s | the patch passed
| +1 | checkstyle | 0m 10s | the patch passed
| +1 | mvneclipse | 0m 11s | the patch passed
| +1 | whitespace | 0m 0s | Patch has no whitespace issues.
| +1 | hadoopcheck | 4m 28s | Patch does not cause any errors with
| | | | Hadoop 2.4.1 2.5.2 2.6.0.
| +1 | findbugs | 1m 7s | the patch passed
| -1 | javadoc | 0m 17s | hbase-client in the patch failed with
| | | | JDK v1.8.0_66.
| +1 | javadoc | 0m 19s | the patch passed with JDK v1.7.0_91
| +1 | unit | 1m 29s | hbase-client in the patch passed with
| | | | JDK v1.8.0_66.
| +1 | unit | 1m 34s | hbase-client in the patch passed with
| | | | JDK v1.7.0_91.
| +1 | asflicense | 0m 8s | Patch does not generate ASF License
| | | | warnings.
| | | 18m 29s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2015-12-17 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12778268/HBASE-14989.1.branch-1.patch
|
| JIRA Issue | HBASE-14989 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 61aa5cc60f39 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-1 / 6ec9228 |
| findbugs | v3.0.0 |
| findbugs | /testptch/patchprocess/branch-findbugs-hbase-client-warnings.html |
| javadoc | /testptch/patchprocess/branch-javadoc-hbase-client-jdk1.8.0_66.txt |
| javadoc | /testptch/patchprocess/patch-javadoc-hbase-client-jdk1.8.0_66.txt |
| JDK v1.7.0_91 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/19/testReport/ |
| modules | C: hbase-client U: hbase-client |
| Max memory used | 126MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/19/console |
The javadoc under java 1.8 bit is already present. While I'd like a test, I
don't think it's a blocker since this is in a deprecated method.
> Implementation of Mutation.getWriteToWAL() is backwards
> -------------------------------------------------------
>
> Key: HBASE-14989
> URL: https://issues.apache.org/jira/browse/HBASE-14989
> Project: HBase
> Issue Type: Bug
> Reporter: James Taylor
> Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4
>
> Attachments: HBASE-14989.1.branch-1.patch,
> hbase-14989-branch-1_v1.patch
>
>
> The implementation of the deprecated getWriteToWAL is backwards. It should
> return true if this.durability == Durability.SYNC_WAL:
> {code}
> /**
> * @deprecated Use {@link #getDurability()} instead.
> * @return true if edits should be applied to WAL, false if not
> */
> @Deprecated
> public boolean getWriteToWAL() {
> return this.durability == Durability.SKIP_WAL;
> }
> {code}
> For example, if mutation.durability is Durability.SYNC_WAL and the following
> code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it
> will disable writing to the WAL for clonedMutation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
