[
https://issues.apache.org/jira/browse/HBASE-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062732#comment-15062732
]
Sean Busbey commented on HBASE-14964:
-------------------------------------
The unit tests pass.
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 0s | Docker mode activated.
| +1 | hbaseanti | 0m 0s | Patch does not have any anti-patterns.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or
| | | | modified test files.
| +1 | mvninstall | 3m 58s | branch-1 passed
| +1 | compile | 0m 46s | branch-1 passed with JDK v1.8.0_66
| +1 | compile | 0m 49s | branch-1 passed with JDK v1.7.0_91
| +1 | checkstyle | 0m 30s | branch-1 passed
| +1 | mvneclipse | 0m 33s | branch-1 passed
| -1 | findbugs | 0m 58s | hbase-client in branch-1 has 17 extant
| | | | Findbugs warnings.
| -1 | findbugs | 1m 55s | hbase-server in branch-1 has 92 extant
| | | | Findbugs warnings.
| -1 | javadoc | 0m 18s | hbase-client in branch-1 failed with
| | | | JDK v1.8.0_66.
| -1 | javadoc | 0m 27s | hbase-server in branch-1 failed with
| | | | JDK v1.8.0_66.
| +1 | javadoc | 0m 51s | branch-1 passed with JDK v1.7.0_91
| +1 | mvninstall | 1m 0s | the patch passed
| +1 | compile | 0m 45s | the patch passed with JDK v1.8.0_66
| +1 | javac | 0m 45s | the patch passed
| +1 | compile | 0m 49s | the patch passed with JDK v1.7.0_91
| +1 | javac | 0m 49s | the patch passed
| -1 | checkstyle | 0m 10s | Patch generated 2 new checkstyle issues
| | | | in hbase-client (total was 1, now 2).
| -1 | checkstyle | 0m 14s | Patch generated 5 new checkstyle issues
| | | | in hbase-server (total was 11, now 16).
| +1 | mvneclipse | 0m 26s | the patch passed
| +1 | whitespace | 0m 0s | Patch has no whitespace issues.
| +1 | hadoopcheck | 4m 6s | Patch does not cause any errors with
| | | | Hadoop 2.4.1 2.5.2 2.6.0.
| +1 | findbugs | 3m 2s | the patch passed
| -1 | javadoc | 0m 15s | hbase-client in the patch failed with
| | | | JDK v1.8.0_66.
| -1 | javadoc | 0m 23s | hbase-server in the patch failed with
| | | | JDK v1.8.0_66.
| +1 | javadoc | 0m 50s | the patch passed with JDK v1.7.0_91
| +1 | unit | 1m 23s | hbase-client in the patch passed with
| | | | JDK v1.8.0_66.
| +1 | unit | 78m 7s | hbase-server in the patch passed with
| | | | JDK v1.8.0_66.
| +1 | unit | 1m 40s | hbase-client in the patch passed with
| | | | JDK v1.7.0_91.
| +1 | unit | 82m 46s | hbase-server in the patch passed with
| | | | JDK v1.7.0_91.
| +1 | asflicense | 0m 29s | Patch does not generate ASF License
| | | | warnings.
| | | 188m 9s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2015-12-17 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12778270/HBASE-14964.1.branch-1.patch
|
| JIRA Issue | HBASE-14964 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux 43836f439275 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-1 / 6ec9228 |
| findbugs | v3.0.0 |
| findbugs | /testptch/patchprocess/branch-findbugs-hbase-client-warnings.html |
| findbugs | /testptch/patchprocess/branch-findbugs-hbase-server-warnings.html |
| javadoc | /testptch/patchprocess/branch-javadoc-hbase-client-jdk1.8.0_66.txt |
| javadoc | /testptch/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_66.txt |
| checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-client.txt |
| checkstyle | /testptch/patchprocess/diff-checkstyle-hbase-server.txt |
| javadoc | /testptch/patchprocess/patch-javadoc-hbase-client-jdk1.8.0_66.txt |
| javadoc | /testptch/patchprocess/patch-javadoc-hbase-server-jdk1.8.0_66.txt |
| JDK v1.7.0_91 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/20/testReport/ |
| modules | C: hbase-client hbase-server U: . |
| Max memory used | 126MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build-rewrite/20/console |
The javadoc and findbugs stuff are things we have to clean up in the codebase;
not your problem.
Sorry those details aren't links. It's not running live yet. They're all
[archived as build artifacts for build #20, for as long as jenkins retains
it|https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-HBASE-Build-rewrite/20/artifact/patchprocess/]
> Backport HBASE-14901 to brach-1 - There is duplicated code to create/manage
> encryption keys
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-14964
> URL: https://issues.apache.org/jira/browse/HBASE-14964
> Project: HBase
> Issue Type: Improvement
> Components: encryption
> Reporter: Nate Edel
> Assignee: Nate Edel
> Priority: Minor
> Fix For: 1.3.0
>
> Attachments: HBASE-14964-branch-1.1.patch,
> HBASE-14964.1.branch-1.patch, HBASE-14964.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> There is duplicated code from MobUtils.createEncryptionContext in HStore, and
> there is a subset of that code in HFileReaderImpl.
> Refactored key selection
> Moved both to EncryptionUtil.java
> Can't figure out how to write a unit test for this, but there's no new code
> just refactoring.
> A lot of the Mob stuff hasn't been backported, so this is a very small patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
