[
https://issues.apache.org/jira/browse/HBASE-14989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064828#comment-15064828
]
Enis Soztutar commented on HBASE-14989:
---------------------------------------
bq. ... which is how mvn says a test hung.... didn't complete.... If I run the
hang detector, I find the below... which is a hanging test. Needs fix up. Need
to integrate this hang check into yetus somehow so don't have to do this
external tool run.
Thanks Stack, you would expect a test framework like surefire to print out
hanging tests, because it is its job. Anyway, script seems very useful.
> Implementation of Mutation.getWriteToWAL() is backwards
> -------------------------------------------------------
>
> Key: HBASE-14989
> URL: https://issues.apache.org/jira/browse/HBASE-14989
> Project: HBase
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Enis Soztutar
> Fix For: 1.2.0, 1.3.0, 1.1.4, 0.98.17, 1.0.4
>
> Attachments: HBASE-14989.1.branch-1.patch,
> hbase-14989-branch-1_v1.patch
>
>
> The implementation of the deprecated getWriteToWAL is backwards. It should
> return true if this.durability == Durability.SYNC_WAL:
> {code}
> /**
> * @deprecated Use {@link #getDurability()} instead.
> * @return true if edits should be applied to WAL, false if not
> */
> @Deprecated
> public boolean getWriteToWAL() {
> return this.durability == Durability.SKIP_WAL;
> }
> {code}
> For example, if mutation.durability is Durability.SYNC_WAL and the following
> code is called {{clonedMutation.setWriteToWAL(mutation.getWriteToWAL())}}, it
> will disable writing to the WAL for clonedMutation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
