[
https://issues.apache.org/jira/browse/HBASE-14940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067501#comment-15067501
]
Anoop Sam John commented on HBASE-14940:
----------------------------------------
The required code is in Bits.java#unaligned() which is a static private
method. Can do reflection call on that. As it is a private class and private
method in Java in future if Java make any changes to Class name or method name
or signature, we may land in issues.. That is why I decided to copy paste the
code.
So if there is a consensus to use Reflection based look up, I can change it.
Patch is committed to trunk already. I can do the needful change as addendum
commit.
> Make our unsafe based ops more safe
> -----------------------------------
>
> Key: HBASE-14940
> URL: https://issues.apache.org/jira/browse/HBASE-14940
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Attachments: HBASE-14940.patch, HBASE-14940_branch-1.patch,
> HBASE-14940_branch-1.patch, HBASE-14940_branch-1.patch
>
>
> Thanks for the nice findings [~ikeda]
> This jira solves 3 issues with Unsafe operations and ByteBufferUtils
> 1. We can do sun unsafe based reads and writes iff unsafe package is
> available and underlying platform is having unaligned-access capability. But
> we were missing the second check
> 2. Java NIO is doing a chunk based copy while doing Unsafe copyMemory. The
> max chunk size is 1 MB. This is done for "A limit is imposed to allow for
> safepoint polling during a large copy" as mentioned in comments in Bits.java.
> We are also going to do same way
> 3. In ByteBufferUtils, when Unsafe is not available and ByteBuffers are off
> heap, we were doing byte by byte operation (read/copy). We can avoid this and
> do better way.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
