[ https://issues.apache.org/jira/browse/HBASE-15021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067605#comment-15067605 ]
stack commented on HBASE-15021: ------------------------------- I think I broke it adding in an export.. .it overshadowed the return from the grep of unit test cases. Let me try this patch: {code} diff --git a/dev-support/test-patch.sh b/dev-support/test-patch.sh index 9366319..509edeb 100755 --- a/dev-support/test-patch.sh +++ b/dev-support/test-patch.sh @@ -841,14 +841,13 @@ runTests () { echo "======================================================================" echo "" echo "" - failed_tests="" echo "$MVN clean test -Dsurefire.rerunFailingTestsCount=2 -P runAllTests -D${PROJECT_NAME}PatchProcess" export MAVEN_OPTS="${MAVEN_OPTS}" ulimit -a - $MVN clean test -Dsurefire.rerunFailingTestsCount=2 -P runAllTests -D${PROJECT_NAME}PatchProcess # Need to export this so the zombie subshell picks up current content export JIRA_COMMENT + $MVN clean test -Dsurefire.rerunFailingTestsCount=2 -P runAllTests -D${PROJECT_NAME}PatchProcess if [[ $? != 0 ]] ; then ### Find and format names of failed tests {code} > hadoopqa doing false positives > ------------------------------ > > Key: HBASE-15021 > URL: https://issues.apache.org/jira/browse/HBASE-15021 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: stack > Attachments: 15021.patch, 15021.thrownpe.patch > > > https://builds.apache.org/job/PreCommit-HBASE-Build/16930/consoleText says: > {color:green}+1 core tests{color}. The patch passed unit tests in . > ...but here is what happened: > {code} > ... > Results : > Tests in error: > org.apache.hadoop.hbase.regionserver.TestRSStatusServlet.testBasic(org.apache.hadoop.hbase.regionserver.TestRSStatusServlet) > Run 1: TestRSStatusServlet.testBasic:105 � NullPointer > Run 2: TestRSStatusServlet.testBasic:105 � NullPointer > Run 3: TestRSStatusServlet.testBasic:105 � NullPointer > org.apache.hadoop.hbase.regionserver.TestRSStatusServlet.testWithRegions(org.apache.hadoop.hbase.regionserver.TestRSStatusServlet) > Run 1: TestRSStatusServlet.testWithRegions:119 � NullPointer > Run 2: TestRSStatusServlet.testWithRegions:119 � NullPointer > Run 3: TestRSStatusServlet.testWithRegions:119 � NullPointer > Tests run: 1033, Failures: 0, Errors: 2, Skipped: 21 > ... > [INFO] Apache HBase - Server ............................. FAILURE > [17:54.559s] > ... > {code} > Why we reporting pass when it failed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)