[
https://issues.apache.org/jira/browse/HBASE-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071773#comment-15071773
]
Hadoop QA commented on HBASE-14800:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12777382/HBASE-14800.003.patch
against master branch at commit 1c7e9ec124ab19d3c727d8294a8022d7b936bbfc.
ATTACHMENT ID: 12777382
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ checkAndMutate_call method_call = new checkAndMutate_call(table,
row, family, qualifier, compareOp, value, rowMutations, resultHandler, this,
___protocolFactory, ___transport);
+ result.success = iface.checkAndMutate(args.table, args.row,
args.family, args.qualifier, args.compareOp, args.value, args.rowMutations);
+ public AsyncMethodCallback<Boolean> getResultHandler(final
AsyncFrameBuffer fb, final int seqid) {
+ iface.checkAndMutate(args.table, args.row, args.family,
args.qualifier, args.compareOp, args.value, args.rowMutations,resultHandler);
+ private static final Map<Class<? extends IScheme>, SchemeFactory> schemes
= new HashMap<Class<? extends IScheme>, SchemeFactory>();
+ /** The set of fields this struct contains, along with convenience methods
for finding and manipulating them. */
+ if (fields == null) throw new IllegalArgumentException("Field " +
fieldId + " doesn't exist!");
+ this.table = table == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(table, table.length));
+ this.family = family == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(family, family.length));
+ this.qualifier = qualifier == null ? (ByteBuffer)null :
ByteBuffer.wrap(Arrays.copyOf(qualifier, qualifier.length));
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/17033//console
This message is automatically generated.
> Expose checkAndMutate via Thrift2
> ---------------------------------
>
> Key: HBASE-14800
> URL: https://issues.apache.org/jira/browse/HBASE-14800
> Project: HBase
> Issue Type: Improvement
> Components: Thrift
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14800.001.patch, HBASE-14800.002.patch,
> HBASE-14800.003.patch
>
>
> Had a user ask why checkAndMutate wasn't exposed via Thrift2.
> I see no good reason (since checkAndPut and checkAndDelete are already
> there), so let's add it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
