[ 
https://issues.apache.org/jira/browse/HBASE-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073617#comment-15073617
 ] 

Hadoop QA commented on HBASE-12593:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12779664/HBASE-12593.patch
  against master branch at commit 6868c6366002d5b4e25980f37ede8839e7a7e92d.
  ATTACHMENT ID: 12779664

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 99 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
new checkstyle errors. Check build console for list of new errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  private static Iterator<Tag> tagsIterator(final ByteBuffer tags, final 
int offset, final int length) {
+  public static Pair<Integer, Integer> readRawVarint32(ByteBuffer input, int 
offset) throws IOException {
+                  newTags.add(new ArrayBackedTag(TagType.TTL_TAG_TYPE, 
Bytes.toBytes(mutate.getTTL())));
+                  newTags.add(new ArrayBackedTag(TagType.TTL_TAG_TYPE, 
Bytes.toBytes(mutate.getTTL())));
+                newTags.add(new ArrayBackedTag(TagType.TTL_TAG_TYPE, 
Bytes.toBytes(mutation.getTTL())));
+                  nonVisTags.add(new 
ArrayBackedTag(TagType.STRING_VIS_TAG_TYPE, modifiedVisExpression));

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this 
patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of 
the build.

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/17053//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/17053//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/17053//artifact/patchprocess/checkstyle-aggregate.html

                Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/17053//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/17053//console

This message is automatically generated.

> Tags to work with ByteBuffer
> ----------------------------
>
>                 Key: HBASE-12593
>                 URL: https://issues.apache.org/jira/browse/HBASE-12593
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-12593.patch
>
>
> Adding the subtask so that we don't forget it. Came up while reviewing the 
> items required for this parent task.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to