[ 
https://issues.apache.org/jira/browse/HBASE-15073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086112#comment-15086112
 ] 

Mikhail Antonov commented on HBASE-15073:
-----------------------------------------

I'd prefer to rename NORMALIZATION_ENABLED flag to something liek 
NORMALIZATION_MODE or something similar. _ENABLED suffix strongly implies 
boolean type, and using it for letter-encoded list of actions is confusing to 
me. It's not yet release so we can do that; after release, it won't be until 
2.0 we can change it, and likely even then there would be back pressure.

Style-wise I think it's better to return empty list rather than null from 
HTD#getDesiredNormalizationTypes().

Looks good otherwise.



> Finer grained control over normalization actions for RegionNormalizer
> ---------------------------------------------------------------------
>
>                 Key: HBASE-15073
>                 URL: https://issues.apache.org/jira/browse/HBASE-15073
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 15073-v1.txt, 15073-v2.txt, 15073-v2.txt, 15073-v3.txt
>
>
> Currently both region split and merge actions are carried out during 
> normalization for underlying table.
> However, for certain use case(s), it would be desirable to perform only one 
> type of action.
> There is one boolean flag, keyed by NORMALIZATION_ENABLED_KEY, per table that 
> enables normalization.
> To provide finer grained control, we have several options:
> 1. introduce another per table flag to indicate which type(s) of actions are 
> allowed ("N" for disabled, "S" for split only, "M" for merge only and "MS" 
> for both split and merge)
> 2. introduce another global flag to indicate which type(s) of actions are 
> allowed
> 3. modify the meaning of existing flag keyed by NORMALIZATION_ENABLED_KEY so 
> that it indicates type(s) of actions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to