[ 
https://issues.apache.org/jira/browse/HBASE-15076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086850#comment-15086850
 ] 

ramkrishna.s.vasudevan commented on HBASE-15076:
------------------------------------------------

AFter seeing the code
{code}
  protected RegionScanner getScanner(Scan scan, List<KeyValueScanner> 
additionalScanners,
      boolean copyCellsFromSharedMem) throws IOException {
{code}
This API is called by 
{code}
public RegionScanner getScanner(Scan scan, boolean copyCellsFromSharedMem) 
throws IOException {
{code}
And am not very sure why the need of additionalScanners came when it is not 
exposed also. May be am missing something here. 

> make the HRegion.getScanner(Scan scan, List<KeyValueScanner> 
> additionalScanners, boolean copyCellsFromSharedMem) to be public
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15076
>                 URL: https://issues.apache.org/jira/browse/HBASE-15076
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: liu ming
>            Assignee: liu ming
>
> HRegion method getScanner(Scan scan, List<KeyValueScanner> 
> additionalScanners, boolean copyCellsFromSharedMem) is protected.
> In Apache Trafodion, we need to invoke this getScanner method from a 
> coprocessor. Since it is protected, Trafodion must overload the HRegion class 
> and overload this method into a public method.
> It will be good to make this method public.
> It is very useful when one needs to combine several scan result in a single 
> scanner.
> thanks,
> Ming



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to