[ https://issues.apache.org/jira/browse/HBASE-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088441#comment-15088441 ]
stack commented on HBASE-13525: ------------------------------- Suggest hoisting your how-to-run-it up to release note. Is test-patch missing from this patch? I see this patch removes test-patch.sh but it does not seem to include test-patch. I see this in personality: + PATCH_BRANCH_DEFAULT=master So, how do I run a patch against an old branch now? Does the trick where you add the branch name to the patch name work still? This list is impressive but a little OCD: 54 + HBASE_HADOOP_VERSIONS="2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1" I suppose it makes sense to have this on hadoop-qa to catch the fail before it gets committed. We can turn this down on other builds? This seems to be untrue now: "....even though we're not including that yet." regards zombie bq. # TODO line length check? could ignore all java files since checkstyle gets them. ... and does a better job of it. Sounds good to me. +1 for commit and fixing teething issues later. > Update test-patch to leverage Apache Yetus > ------------------------------------------ > > Key: HBASE-13525 > URL: https://issues.apache.org/jira/browse/HBASE-13525 > Project: HBase > Issue Type: Improvement > Components: build > Reporter: Sean Busbey > Assignee: Sean Busbey > Labels: jenkins > Fix For: 2.0.0 > > Attachments: HBASE-13525.1.patch > > > Once HADOOP-11746 lands over in Hadoop, incorporate its changes into our > test-patch. Most likely easiest approach is to start with the Hadoop version > and add in the features we have locally that they don't. -- This message was sent by Atlassian JIRA (v6.3.4#6332)