[
https://issues.apache.org/jira/browse/HBASE-15082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091486#comment-15091486
]
ramkrishna.s.vasudevan commented on HBASE-15082:
------------------------------------------------
Had a quick look at the patch. Lots of clean up related to DLR. No more
rollbackMemstore because it is first append and sync to WAL and then add to
memstore.
bq. Iterator<Tag> itr =
CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(),
cell.getTagsLength());
In TagUtil.carryForwardTags the above method is deprecated. Stil you wanted to
go with it because you always wanted an onheap KV even from the BBCell right?
I think only if the entire offheap write path is done we could use the
CellUtil.tagsIterator(Cell) method.
> Fix merge of MVCC and SequenceID performance regression
> -------------------------------------------------------
>
> Key: HBASE-15082
> URL: https://issues.apache.org/jira/browse/HBASE-15082
> Project: HBase
> Issue Type: Sub-task
> Components: Performance
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: 15082.patch, 15082v2.patch, 15082v2.txt, 15082v3.txt,
> 15082v4.patch, 15082v5.patch, 15082v6.patch, 15082v7.patch
>
>
> This is general fix for increments (appends, checkAnd*) perf-regression
> identified in the parent issue. HBASE-15031 has a narrow fix for branch-1.1
> and branch-1.0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
