[ 
https://issues.apache.org/jira/browse/HBASE-4684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144265#comment-13144265
 ] 

jack levin commented on HBASE-4684:
-----------------------------------

Here is applicable patch for 0.90.4 (tested to work):

— src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
+++ src/main/java/org/apache/hadoop/hbase/rest/TableResource.java
@@ -37,6 +37,7 @@
import org.apache.hadoop.hbase.HColumnDescriptor;
import org.apache.hadoop.hbase.HConstants;
import org.apache.hadoop.hbase.HTableDescriptor;
+import org.apache.hadoop.hbase.client.HConnectionManager;
import org.apache.hadoop.hbase.TableNotFoundException;
import org.apache.hadoop.hbase.client.HBaseAdmin;
import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
@@ -135,6 +136,7 @@
try {
HBaseAdmin admin = new HBaseAdmin(servlet.getConfiguration());
HTableDescriptor htd = admin.getTableDescriptor(Bytes.toBytes(table));
+ HConnectionManager.deleteConnection(admin.getConfiguration(), false);
for (HColumnDescriptor hcd: htd.getFamilies()) {
for (Map.Entry<ImmutableBytesWritable, ImmutableBytesWritable> e:
hcd.getValues().entrySet()) {

  


                
> REST server is leaking ZK connections in 0.90
> ---------------------------------------------
>
>                 Key: HBASE-4684
>                 URL: https://issues.apache.org/jira/browse/HBASE-4684
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.4
>            Reporter: Jean-Daniel Cryans
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 0.90.5
>
>         Attachments: HBASE-4684-0.90.patch, HBASE-4684-v2-0.90.patch
>
>
> As reported a month ago, http://search-hadoop.com/m/FD6gmKzrxY1, the REST 
> server is leak ZK connections. Upon investigation I see that 
> TableResource.scanTransformAttrs creates a new HBA per minute per table (when 
> the server is getting requests) but never deletes the connection created in 
> there.
> There are a bunch of other places where HBAs are created but not cleaned 
> after like SchemaResource, StorageClusterStatusResource, 
> StorageClusterVersionResource, ExistsResource, etc. Those places shouldn't be 
> as leaky under normal circumstances tho.
> Thanks to Jack Levin for bringing up this issue again when he tried to 
> upgrade.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to