[
https://issues.apache.org/jira/browse/HBASE-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093911#comment-15093911
]
Anoop Sam John commented on HBASE-15055:
----------------------------------------
new method isPeriodicMC() is having code copied from isMajorCompaction. The
latter one is doing some more work indeed. No problem in adding the new
method. Can the old one make use of the old and avoid duplication?
{code}
boolean isTryingMajor = (forceMajor && isAllFiles && isUserCompaction)
109 || (((forceMajor && isAllFiles) || (isAllFiles && isPeriodicMC)
110 || isMajorCompaction(candidateSelection))
{code}
The || condition may bypass the call to isMajorCompaction and avoid the further
checks it is doing.
> Major compaction is not triggered when both of TTL and
> hbase.hstore.compaction.max.size are set
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-15055
> URL: https://issues.apache.org/jira/browse/HBASE-15055
> Project: HBase
> Issue Type: Bug
> Reporter: Eungsop Yoo
> Assignee: Eungsop Yoo
> Priority: Minor
> Attachments: HBASE-15055-v1.patch, HBASE-15055-v10.patch,
> HBASE-15055-v2.patch, HBASE-15055-v3.patch, HBASE-15055-v4.patch,
> HBASE-15055-v5.patch, HBASE-15055-v6.patch, HBASE-15055-v7.patch,
> HBASE-15055-v8.patch, HBASE-15055-v9.patch, HBASE-15055.patch
>
>
> Some large files may be skipped by hbase.hstore.compaction.max.size in
> candidate selection. It causes skipping of major compaction. So the TTL
> expired records are still remained in the disks and keep consuming disks.
> To resolve this issue, I suggest that to skip large files only if there is no
> TTL expired record.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
