[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098213#comment-15098213
]
Anoop Sam John commented on HBASE-15101:
----------------------------------------
Analysis seems reasonable. Any other places we missed like this? ! Need to
check but any way as another jira.
{code}
if (kvs.shouldUseScanner(scan, store, expiredTimestampCutoff)) {
416 selectedScanners.add(kvs);
417 } else {
418 ignoredScanners.add(kvs);
419 }
{code}
Can we just change the existing method selectScannersFrom and instead of adding
to new list just directly close there? No need to have the over head of
another ArrayList and Pair creation. Can simple direct change.
> Leaked References to StoreFile.Reader after HBASE-13082
> -------------------------------------------------------
>
> Key: HBASE-15101
> URL: https://issues.apache.org/jira/browse/HBASE-15101
> Project: HBase
> Issue Type: Bug
> Components: HFile, io
> Affects Versions: 2.0.0
> Reporter: deepankar
> Attachments: HBASE-15101.patch
>
>
> We observed this production that after a region server dies there are huge
> number of hfiles in that region for the region server running the version
> with HBASE-13082, In the doc it is given that it is expected to happen, but
> we found a one place where scanners are not being closed. If the scanners are
> not closed their references are not decremented and that is leading to the
> issue of huge number of store files not being finalized
> All I was able to find is in the selectScannersFrom, where we discard some of
> the scanners and we are not closing them. I am attaching a patch for that.
> Also to avoid these issues should the files that are done be logged and
> finalized (moved to archive) as a part of region close operation. This will
> solve any leaks that can happen and does not cause any dire consequences?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
