[ 
https://issues.apache.org/jira/browse/HBASE-4740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144485#comment-13144485
 ] 

Jonathan Hsieh commented on HBASE-4740:
---------------------------------------

@Stack

Yeah, 0 is actually the original behavior in the pre-HBASE-4552 version it I 
think would just eat exceptions and bail out without completing.  It is more 
complicated because of bulk atomicity.

Will update boolean if it works --  there is some template checking in another 
place so assumed it needed boxed type.

The difference is that the version uses a different LoadIncrementalHandlers 
instance.  I'll refactor to exclude that portion and require it in the test.

I tried the previous version with a small data set on psuedo-dist cluster and 
live cluster.  For this particular patch I tried this one by looping the 
relevant unit tests 100 times and seeing that they passed all the time.  I 
haven't tested this exact version on real cluster. 


                
> [bulk load]  the HBASE-4552 API can't tell if errors on region server is 
> recoverable or unrecoverable error.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4740
>                 URL: https://issues.apache.org/jira/browse/HBASE-4740
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>            Priority: Blocker
>             Fix For: 0.92.0
>
>         Attachments: 
> 0001-HBASE-4740-bulkload-HBASE-4552-API-can-t-tell-if-err.patch
>
>
> Running TestHFileOutputFormat more frequently seems to show that it has 
> become flaky.   It is difficult to tell if this is because of a unrecoverable 
> failure or a recoverable failure.   To make this visiable from test and for 
> users, we need to make a change to bulkload call's interface on 
> HRegionServer.  The change should make successful rpcs return true, 
> recoverable failures return false, and unrecoverable failure throw an 
> IOException.  This is an RPC change, so it would be really good to get this 
> api right before the final 0.92 goes out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to