[
https://issues.apache.org/jira/browse/HBASE-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102616#comment-15102616
]
Mikhail Antonov commented on HBASE-15075:
-----------------------------------------
Briefly looked at the patch, some thoughts / question (unless I'm missing
something here)..
We're maintaining now map of UUID->split plan in SplitNormalizationPlan in
static map, would it be better to keep in in *RegionNormalizer instead?
Also we're generating id here in #execute() call, and sending plan with
attached UUID out, uuid is getting passed thru, but we don't really account
whether issued plan failed or not? In other words, there should be a map of
failedPlans, not (just) recent plans?
> Allow region split request to carry identification information
> --------------------------------------------------------------
>
> Key: HBASE-15075
> URL: https://issues.apache.org/jira/browse/HBASE-15075
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: 15075-v0.txt, 15075-v1.txt, 15075-v2.txt,
> HBASE-15075.v2.patch, HBASE-15075.v3.patch, HBASE-15075.v4.patch,
> HBASE-15075.v5.patch
>
>
> During the process of improving region normalization feature, I found that if
> region split request triggered by the execution of SplitNormalizationPlan
> fails, there is no way of knowing whether the failed split originated from
> region normalization.
> The association of particular split request with outcome of split would give
> RegionNormalizer information so that it can make better normalization
> decisions in the subsequent invocations.
> One approach is to embed metadata, such as a UUID, in SplitRequest which gets
> passed through RegionStateTransitionContext when
> RegionServerServices#reportRegionStateTransition() is called.
> This way, RegionStateListener can be notified with the metadata (id of the
> requester).
> See discussion on dev mailing list
> http://search-hadoop.com/m/YGbbCXdkivihp2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
