[
https://issues.apache.org/jira/browse/HBASE-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103499#comment-15103499
]
Dima Spivak commented on HBASE-15119:
-------------------------------------
Just wondering, do we really need
{noformat}
+JAVA_ACC_COMMAND+=(-v1 ${COMMIT[1]}${SHA[1]+"/${SHA[1]}"})
+JAVA_ACC_COMMAND+=(-v2 ${COMMIT[2]}${SHA[2]+"/${SHA[2]}"})
{noformat}
to be set? Seems to me like just having ${COMMIT[1]}/${SHA[1]} would have the
same effect here (minus an extra slash), but I guess I can't see why revparse
would fail. Otherwise, LGTM.
> Include git SHA in check_compatibility reports
> ----------------------------------------------
>
> Key: HBASE-15119
> URL: https://issues.apache.org/jira/browse/HBASE-15119
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-15119.v00.patch
>
>
> Since some refs change over time (ie, branches), it would be nice to include
> git shas in the version info included in check compatibility reports. It'll
> also help interested parties to be sure of what they're looking at.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
