[ 
https://issues.apache.org/jira/browse/HBASE-15098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103577#comment-15103577
 ] 

stack commented on HBASE-15098:
-------------------------------

bq.  We should implement a proper if statement that checks this value and 
properly disables the feature cluster wide if not wanted.

A kill switch @lars george? I think it good that the 'normalizing' feature is 
'on' by default but only has an effect if you ask for it in a table attribute. 
In that case, the attached patch would make sense; it cleans up a config left 
over from when the though was you'd opt in. But if you want a kill switch, we 
should bring back the config and make code take notice (Myself, I don't think 
we need a kill switch). Thanks Lars.

> Normalizer switch in configuration is not used
> ----------------------------------------------
>
>                 Key: HBASE-15098
>                 URL: https://issues.apache.org/jira/browse/HBASE-15098
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.2.0
>            Reporter: Lars George
>            Priority: Blocker
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-15098.v1.patch
>
>
> The newly added global switch to enable the new normalizer functionality is 
> never used apparently, meaning it is always on. The {{hbase-default.xml}} has 
> this:
> {noformat}
>   <property>
>     <name>hbase.normalizer.enabled</name>
>     <value>false</value>
>     <description>If set to true, Master will try to keep region size
>       within each table approximately the same.</description>
>   </property>
> {noformat}
> But only a test class uses it to set the switch to "true". We should 
> implement a proper {{if}} statement that checks this value and properly 
> disables the feature cluster wide if not wanted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to