[
https://issues.apache.org/jira/browse/HBASE-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144567#comment-13144567
]
[email protected] commented on HBASE-2425:
------------------------------------------------------
bq. On 2011-11-04 18:06:38, Gary Helmling wrote:
bq. > src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java, line 60
bq. > <https://reviews.apache.org/r/2718/diff/1/?file=56227#file56227line60>
bq. >
bq. > Should be able to remove this now that Invocation implements
VersionedWritable.
bq.
bq. Michael Stack wrote:
bq. Agreed.
oh, I see what you mean. Invocation is now versioned and will fail on
deserialization.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2718/#review3049
-----------------------------------------------------------
On 2011-11-04 00:11:21, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2718/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-04 00:11:21)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Versions of Gary suggestions
bq.
bq.
bq. This addresses bug hbase-2425.
bq. https://issues.apache.org/jira/browse/hbase-2425
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
fce5490
bq. src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java
2fa4d6f
bq.
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
6f88357
bq. src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java
6fcb771
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1365411
bq. src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 4a8918a
bq. src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java e60f970
bq. src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java fb07374
bq. src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 60a9248
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
8de2314
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 0d0e4c5
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
12bd33e
bq. src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 888f428
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
e5b6a78
bq.
bq. Diff: https://reviews.apache.org/r/2718/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Crossport HADOOP-1849 rpc fix
> -----------------------------
>
> Key: HBASE-2425
> URL: https://issues.apache.org/jira/browse/HBASE-2425
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Labels: moved_from_0_20_5
>
> Suggested over in HBASE-2360.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira