[
https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108082#comment-15108082
]
Anoop Sam John commented on HBASE-15101:
----------------------------------------
+1
Ya that addition of close(false) will not impact any thing. And of no use
also. This will just add the scanner to the delayedClosing Set. In KVHeap
upper layer any way based on the return boolean we will add this StoreScanner
itself into its delayedClosing Set. The shipped call come 1st to KVHeap and
there it will close() this StoreScanner fully. (Which will close every thing
and clear) And there wont be any shipped () call on this SToreScanner at all..
So 1st addition to delayedClosing Set in StoreScanner is of no value. Any way
no harm also. So go for commit.
ANy way we dont need the Set in StoreScanner now and that we can do in another
IA jira.
> Leaked References to StoreFile.Reader after HBASE-13082
> -------------------------------------------------------
>
> Key: HBASE-15101
> URL: https://issues.apache.org/jira/browse/HBASE-15101
> Project: HBase
> Issue Type: Bug
> Components: HFile, io
> Affects Versions: 2.0.0
> Reporter: deepankar
> Assignee: deepankar
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-15101-v1.patch, HBASE-15101-v2.patch,
> HBASE-15101-v3.patch, HBASE-15101-v4.patch, HBASE-15101.patch
>
>
> We observed this production that after a region server dies there are huge
> number of hfiles in that region for the region server running the version
> with HBASE-13082, In the doc it is given that it is expected to happen, but
> we found a one place where scanners are not being closed. If the scanners are
> not closed their references are not decremented and that is leading to the
> issue of huge number of store files not being finalized
> All I was able to find is in the selectScannersFrom, where we discard some of
> the scanners and we are not closing them. I am attaching a patch for that.
> Also to avoid these issues should the files that are done be logged and
> finalized (moved to archive) as a part of region close operation. This will
> solve any leaks that can happen and does not cause any dire consequences?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
