[
https://issues.apache.org/jira/browse/HBASE-14841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112893#comment-15112893
]
stack commented on HBASE-14841:
-------------------------------
Looks like a few things to fix (a findbugs, whitespace).
On the patch, looks good.
Does this test for a BBCell have to out here in this BufferedDataBlockEncoder
class?
1007 if (cell instanceof ByteBufferedCell) {
1008 tagCompressionContext.compressTags(out, ((ByteBufferedCell)
cell).getTagsByteBuffer(),
1009 ((ByteBufferedCell) cell).getTagsPosition(), tagsLength);
1010 } else {
1011 tagCompressionContext.compressTags(out,
cell.getTagsArray(), cell.getTagsOffset(),
1012 tagsLength);
1013 }
You fellows have been doing good job of containing the test of Cell type inside
stuff like CellUtil... is this a violation of your rule?
Checkstyle will flag no brackets here:
592 for (int i = offset; i < offset + length; i++)
593 hash = (31 * hash) + (int) toByte(buf, i);
Patch LGTM otherwise. Get an Anoop +1 I'd say.
> Allow Dictionary to work with BytebufferedCells
> -----------------------------------------------
>
> Key: HBASE-14841
> URL: https://issues.apache.org/jira/browse/HBASE-14841
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-14841.patch, HBASE-14841_1.patch,
> HBASE-14841_2.patch, HBASE-14841_3.patch
>
>
> This is part of HBASE-14832 where we need to ensure that while BBCells are
> getting compacted the TagCompression part should be working with BBCells.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
