[ 
https://issues.apache.org/jira/browse/HBASE-15162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116695#comment-15116695
 ] 

Yu Li commented on HBASE-15162:
-------------------------------

Thanks for mentioning HBASE-14983, checking the changes there I could see a 
more fine-grained separation on the cache count metrics (great work sir), but I 
didn't see  any hit ratio. It seems you prefer counter to gauge and plan to do 
the aggregation at front-end? Since we already have a gauge for 
blockCacheHitPercent, I think it would be more convenient to supply a gauge for 
meta/dataBlockCacheHitPercent, so user could directly monitor on it rather than 
do additional aggregation.

It's ok for me to merge HBASE-14983 and this JIRA, but I hope we could keep the 
hit ratio gauge and the metrics name proposed here, so we won't need to modify 
our monitoring system in the next upgrade in the future.

> Add separate metrics for meta/data block hit ratio in cache
> -----------------------------------------------------------
>
>                 Key: HBASE-15162
>                 URL: https://issues.apache.org/jira/browse/HBASE-15162
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-15162.patch, HBASE-15162_v2.patch
>
>
> Currently we already have a metrics in name of 
> {{blockCacheExpressHitPercent}} to indicate the cache hit ratio. However, 
> since meta block is small and often cached in memory with a high hit ratio, 
> this "mixed" metrics could not show the real data block hit ratio which is 
> more concerned.
> We propose to add two new metrics to show meta and data block cache hit ratio 
> separately, while reserving the old metrics for backward compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to