[jira] [Commented] (HBASE-14259) Backport Namespace quota support to 98 branch

[Jianwei Cui (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-14259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118848#comment-15118848
 ] 

Jianwei Cui commented on HBASE-14259:
-------------------------------------

Thanks for the patch, [~avandana]. Seems one typo in patch v3?
{code}
+  public void updateQuotaForRegionMerge(HRegionInfo hri) throws IOException {
+    if (isInitialized()) { // ===> if (!isInitialized()) {
+      throw new IOException(
+          "Merge operation is being performed even before namespace auditor is 
initialized.");
+    }
{code}

In TestZKLessNamespaceAuditor, setBoolean("hbase.assignment.usezk", false) will 
be applied to  TestZKLessNamespaceAuditor#UTIL, not TestNamespaceAuditor#UTIL, 
making TestZKLessNamespaceAuditor will also use zookeeper to assign region. 
Need to make TestNamespaceAuditor#UTIL protected?
{code}
+@Category(MediumTests.class)
+public class TestZKLessNamespaceAuditor extends TestNamespaceAuditor {
+  private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();
+
+  @BeforeClass
+  public static void before() throws Exception {
+    UTIL.getConfiguration().setBoolean("hbase.assignment.usezk", false);
+    setupOnce();
+  }
{code}

In AssignmentManager:
{code}
     case MERGED:
     case READY_TO_MERGE:
     case MERGE_PONR:
     case MERGED:
+      try {
+        regionStateListener.onRegionMerged(hri);
+      } catch (IOException exp) {
+        errorMsg = StringUtils.stringifyException(exp);
+      }
{code}
should invoke regionStateListener.onRegionMerged only in MERGED case?
{code}
     case MERGE_PONR:
     case MERGED:
+      if (code == TransitionCode.MERGED) {
+      try {
+        regionStateListener.onRegionMerged(hri);
+      } catch (IOException exp) {
+        errorMsg = StringUtils.stringifyException(exp);
+      }
+      }
{code}

> Backport Namespace quota support to 98 branch 
> ----------------------------------------------
>
>                 Key: HBASE-14259
>                 URL: https://issues.apache.org/jira/browse/HBASE-14259
>             Project: HBase
>          Issue Type: Task
>            Reporter: Vandana Ayyalasomayajula
>            Assignee: Andrew Purtell
>             Fix For: 0.98.18
>
>         Attachments: HBASE-14259_v1_0.98.patch, HBASE-14259_v2_0.98.patch, 
> HBASE-14259_v3_0.98.patch
>
>
> Namespace quota support (HBASE-8410) has been backported to branch-1 
> (HBASE-13438). This jira would backport the same to 98 branch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)