[
https://issues.apache.org/jira/browse/HBASE-9393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121069#comment-15121069
]
Ashish Singhi commented on HBASE-9393:
--------------------------------------
Thanks for the comments.
Sorry for delay in repsonse, I was on holidays.
bq. Adding the below as finally in a method named pickReaderVersion seems a bit
odd... is pickReaderVersion only place we read in the file trailer? That seems
odd (not your issue Ashish Singhi). You'd think we'd want to keep the trailer
around in the reader.
[~anoop.hbase] has already replied for this. Thanks.
bq. Bq. Is it odd adding this unbufferStream to hbase types when there is the
Interface CanUnbuffer up in hdfs? Should we have a local hbase equivalent...
and put it on HFileBlock, HFileReader... Then the relation is more clear?
Perhaps overkill?
>From HBase side we do not have any control over the socket, so I don’t think
>we can do anything here apart from calling the unbuffer api for the stream
>which implements CanBuffer class. I also think this is not needed.
bq. May be we should at least rename this method pickReaderVersion ?
Changed it to openReader as per the suggestion.
Last QA run for v5 was clean. Updated patch addressing method rename comment.
Thanks all again.
> Hbase does not closing a closed socket resulting in many CLOSE_WAIT
> --------------------------------------------------------------------
>
> Key: HBASE-9393
> URL: https://issues.apache.org/jira/browse/HBASE-9393
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.2, 0.98.0
> Environment: Centos 6.4 - 7 regionservers/datanodes, 8 TB per node,
> 7279 regions
> Reporter: Avi Zrachya
> Assignee: Ashish Singhi
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: HBASE-9393.patch, HBASE-9393.v1.patch,
> HBASE-9393.v2.patch, HBASE-9393.v3.patch, HBASE-9393.v4.patch,
> HBASE-9393.v5.patch, HBASE-9393.v5.patch, HBASE-9393.v5.patch,
> HBASE-9393.v6.patch
>
>
> HBase dose not close a dead connection with the datanode.
> This resulting in over 60K CLOSE_WAIT and at some point HBase can not connect
> to the datanode because too many mapped sockets from one host to another on
> the same port.
> The example below is with low CLOSE_WAIT count because we had to restart
> hbase to solve the porblem, later in time it will incease to 60-100K sockets
> on CLOSE_WAIT
> [root@hd2-region3 ~]# netstat -nap |grep CLOSE_WAIT |grep 21592 |wc -l
> 13156
> [root@hd2-region3 ~]# ps -ef |grep 21592
> root 17255 17219 0 12:26 pts/0 00:00:00 grep 21592
> hbase 21592 1 17 Aug29 ? 03:29:06
> /usr/java/jdk1.6.0_26/bin/java -XX:OnOutOfMemoryError=kill -9 %p -Xmx8000m
> -ea -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode
> -Dhbase.log.dir=/var/log/hbase
> -Dhbase.log.file=hbase-hbase-regionserver-hd2-region3.swnet.corp.log ...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
