[ 
https://issues.apache.org/jira/browse/HBASE-15181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122082#comment-15122082
 ] 

Ted Yu commented on HBASE-15181:
--------------------------------

Is this in production ?
If so, can you share performance numbers ?

75        public static final String MAX_AGE = CONFIG_PREFIX + 
"tiered.max.storefile.age";
76        public static final String TIME_UNIT = CONFIG_PREFIX + 
"tiered.time.unit";
77        public static final String TIER_BASE = CONFIG_PREFIX + 
"tiered.tier.base";
78        public static final String MIN_THRESHOLD = CONFIG_PREFIX + 
"tiered.min.threshold";

Please add javadoc for the parameters above.
Normally such constants end with '_KEY'

TieredCompactionPolicy.java needs Apache license. Please add annotation for 
audience and class javadoc.

Putting the next patch on review board would facilitate reviewing.

> A simple implementation of date based tiered compaction
> -------------------------------------------------------
>
>                 Key: HBASE-15181
>                 URL: https://issues.apache.org/jira/browse/HBASE-15181
>             Project: HBase
>          Issue Type: New Feature
>          Components: Compaction
>            Reporter: Clara Xiong
>            Assignee: Clara Xiong
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15181-v1.patch
>
>
> This is a simple implementation of date-based tiered compaction similar to 
> Cassandra's for the following benefits:
> 1. Improve date-range-based scan by structuring store files in date-based 
> tiered layout.
> 2. Reduce compaction overhead.
> 3. Improve TTL efficiency.
> Perfect fit for the use cases that:
> 1. has mostly date-based date write and scan and a focus on the most recent 
> data. 
> 2. never or rarely deletes data.
> Out-of-order writes are handled gracefully so the data will still get to the 
> right store file for time-range-scan and re-compacton with existing store 
> file in the same time window is handled by ExploringCompactionPolicy.
> Time range overlapping among store files is tolerated and the performance 
> impact is minimized.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to