[ 
https://issues.apache.org/jira/browse/HBASE-15128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123977#comment-15123977
 ] 

Enis Soztutar commented on HBASE-15128:
---------------------------------------

bq.  this patch as it is is a -1 to me. because of that set_switch that wants 
to be generic. 
My understanding is that HBASE-13936 is for refactoring the configuration in 
code to be more manageable. It does not aim to do dynamic conf as we describe 
it above. The dynamic conf issue, HBASE-3909 is open for 4+ years. My point is 
that unless I see some progress on these, it does not make sense to hold this 
issue. Heng's proposal seems logical that once we have the dynamic conf 
framework, we can migrate this to using it. 
{{set_switch}} is not trying to be a generic conf framework. It does not allow 
you to change random config values. Maybe we can rename it to something more 
reflective, like set_master_process 

bq. if you want to solve ONLY the disable split/merge. Jon solution with the 
table lock is probably ok, and I also think we use that already in hbck.
Although the original goal was to enable / disable splitting for HBCK, we 
should aim for getting a dynamic behavior for the operator or HBCK to control 
splitting. 

> Disable region splits and merges in HBCK
> ----------------------------------------
>
>                 Key: HBASE-15128
>                 URL: https://issues.apache.org/jira/browse/HBASE-15128
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-15128.patch, HBASE-15128_v1.patch, 
> HBASE-15128_v3.patch
>
>
> In large clusters where region splits are frequent, and HBCK runs take 
> longer, the concurrent splits cause further problems in HBCK since HBCK 
> assumes a static state for the region partition map. We have just seen a case 
> where HBCK undo's a concurrently splitting region causing number of 
> inconsistencies to go up. 
> We can have a mode in master where splits and merges are disabled like the 
> balancer and catalog janitor switches. Master will reject the split requests 
> if regionservers decide to split. This switch can be turned on / off by the 
> admins and also automatically by HBCK while it is running (similar to 
> balancer switch being disabled by HBCK). 
> HBCK  should also disable the Catalog Janitor just in case. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to