[ 
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145251#comment-13145251
 ] 

Phabricator commented on HBASE-4742:
------------------------------------

Liyin has commented on the revision "[jira] [HBASE-4742] Split dead server's 
log in parallel".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:304 I 
have made these threads as daemons threads.

  src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:285 
yes, stale code. I shall remove this function.
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java:306 Good point, 
Prakash.
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java:313 I think all the 
threads created by this thread executor pool will run as daemon mode, which 
means the thread will either run until  it completes or until all User Threads 
have completed.

REVISION DETAIL
  https://reviews.facebook.net/D237

                
> Split dead server's log in parallel
> -----------------------------------
>
>                 Key: HBASE-4742
>                 URL: https://issues.apache.org/jira/browse/HBASE-4742
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch, 
> D237.5.patch, D237.6.patch
>
>
> When one region server goes down, the master will shutdown the region server 
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by 
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the 
> dead servers in parallel. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to