[ 
https://issues.apache.org/jira/browse/HBASE-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15128687#comment-15128687
 ] 

Ted Yu commented on HBASE-15197:
--------------------------------

{code}
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:584:
    @Override:5: error: Method length is 159 lines (max allowed is 150).
{code}
Even if the change in this method doesn't wrap to new line, the length of 
method would still exceed 150.
Nothing to be done for the above warning.

> Expose filtered read requests metric to metrics framework and Web UI
> --------------------------------------------------------------------
>
>                 Key: HBASE-15197
>                 URL: https://issues.apache.org/jira/browse/HBASE-15197
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Eungsop Yoo
>            Assignee: Eungsop Yoo
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15197.patch, HBASE-15197.patch, 
> WebUI-screenshot.png
>
>
> Filtered read requests metric for scan is added in 
> [HBASE-5980|https://issues.apache.org/jira/browse/HBASE-5980]. But it can be 
> retrieved from Scan object only. I think that it would be more informative 
> when it is exposed to metrics framework. So I suggest to add filtered read 
> requests metric and to expose it metrics framework and Web UI.
> ps. I think I found a bug; read requests count increased when Get operation 
> returns no record by filtering out. Should it be fixed?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to