[ https://issues.apache.org/jira/browse/HBASE-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129348#comment-15129348 ]
Hudson commented on HBASE-15158: -------------------------------- FAILURE: Integrated in HBase-Trunk_matrix #674 (See [https://builds.apache.org/job/HBase-Trunk_matrix/674/]) HBASE-15196 HBASE-15158 Preamble 2 of 2:Add Increment tests (stack: rev ed46591f30d4d66e89bc8157fc866c2aad77ce2c) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionReplayEvents.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIncrementsFromClientSide.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIncrementFromClientSideWithCoprocessor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiVersionConcurrencyControl.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java * hbase-server/src/test/java/org/apache/hadoop/hbase/IncrementPerformanceTest.java * hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionIncrement.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSideWithCoprocessor.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ReplayHLogKey.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpointNoMaster.java * hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestIncrement.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicaFailover.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java > Change order in which we do write pipeline operations; do all under row locks! > ------------------------------------------------------------------------------ > > Key: HBASE-15158 > URL: https://issues.apache.org/jira/browse/HBASE-15158 > Project: HBase > Issue Type: Sub-task > Components: Performance > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: 15158.patch, 15158v2.patch, 15158v3.patch > > > Change how we do our write pipeline. I want to do all write pipeline ops > under row lock so I lean on this fact fixing performance regression in > check-and-set type operations like increment, append, and checkAnd* (see > sibling issue HBASE-15082). > To be specific, we write like this now: > {code} > # take rowlock > # start mvcc > # append to WAL > # add to memstore > # let go of rowlock > # sync WAL > # in case of error: rollback memstore > {code} > Instead, write like this: > {code} > # take rowlock > # start mvcc > # append to WAL > # sync WAL > # add to memstore > # let go of rowlock > ... no need to do rollback. > {code} > The old ordering was put in place because it got better performance in a time > when WAL was different and before row locks were read/write (HBASE-12751). > Testing in branch-1 shows that a reordering and skipping mvcc waits gets us > back to the performance we had before we unified mvcc and sequenceid > (HBASE-8763). Tests in HBASE-15046 show that at the macro level using our > usual perf tools, reordering pipeline seems to cause no slowdown (see > HBASE-15046). A rough compare of increments with reordered write pipeline > seems to have us getting back a bunch of our performance (see tail of > https://issues.apache.org/jira/browse/HBASE-15082?focusedCommentId=15111703&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15111703 > and subsequent comment). -- This message was sent by Atlassian JIRA (v6.3.4#6332)