[ 
https://issues.apache.org/jira/browse/HBASE-15218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15134458#comment-15134458
 ] 

ramkrishna.s.vasudevan commented on HBASE-15218:
------------------------------------------------

We were writing and reading the WAL with tags only always even before this fix. 
Only in the place where we were reading the Cell we were skipping the Tag part 
as the length was returned as 0. So as such directly there wont be any impact 
on the WAL writes and reads and only in places where we read the cell we will 
have an impact while checking the tags length. But I think that will happen 
only when replaying the WAL and should not have much impact. 

> On RS crash and replay of WAL, loosing all Tags in Cells
> --------------------------------------------------------
>
>                 Key: HBASE-15218
>                 URL: https://issues.apache.org/jira/browse/HBASE-15218
>             Project: HBase
>          Issue Type: Bug
>          Components: Recovery, regionserver, security
>    Affects Versions: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.0.4, 0.98.18
>
>         Attachments: HBASE-15218.patch
>
>
> The KeyValueCodec's Decoder makes NoTagsKeyValue. The WalCellCodec also makes 
> this Decoder and so while reading Cells after RS crash, we will loose all 
> tags in Cells.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to