[ 
https://issues.apache.org/jira/browse/HBASE-15216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138099#comment-15138099
 ] 

Hadoop QA commented on HBASE-15216:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s 
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s 
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s 
{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
13s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 6s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 34s 
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 19m 
7s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
36s {color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 9m 5s 
{color} | {color:red} branch/. no findbugs output file 
(./target/findbugsXml.xml) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 0s 
{color} | {color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 6s 
{color} | {color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 
47s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 58s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 58s 
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 17s 
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 17s 
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 13m 10s 
{color} | {color:red} Patch generated 2 new checkstyle issues in root (total 
was 15, now 17). {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 30s 
{color} | {color:red} Patch generated 2 new checkstyle issues in hbase-server 
(total was 15, now 17). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 
37s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s 
{color} | {color:red} The patch has 5 line(s) that end in whitespace. Use git 
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s 
{color} | {color:red} The patch has 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
28m 18s {color} | {color:green} Patch does not cause any errors with Hadoop 
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 10m 16s 
{color} | {color:red} patch/. no findbugs output file 
(./target/findbugsXml.xml) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 34s 
{color} | {color:red} hbase-server introduced 1 new FindBugs issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 11s 
{color} | {color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 36s 
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 111m 8s {color} 
| {color:red} root in the patch failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 118m 20s 
{color} | {color:green} hbase-server in the patch passed with JDK v1.8.0_72. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 115m 35s 
{color} | {color:red} root in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 130m 18s 
{color} | {color:red} hbase-server in the patch failed with JDK v1.7.0_95. 
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 
51s {color} | {color:green} Patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 603m 46s {color} 
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
|  |  Dead store to parser in 
org.apache.hadoop.hbase.tool.Canary.main(String[])  At 
Canary.java:org.apache.hadoop.hbase.tool.Canary.main(String[])  At 
Canary.java:[line 1191] |
| JDK v1.7.0_95 Failed junit tests | 
hadoop.hbase.snapshot.TestSecureExportSnapshot |
|   | hadoop.hbase.snapshot.TestSecureExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-08 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12786808/HBASE-15216.v1.patch |
| JIRA Issue | HBASE-15216 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  
hbaseanti  checkstyle  compile  |
| uname | Linux 4cfcc9b9fe40 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed 
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
 |
| git revision | master / ec92a8a |
| findbugs | v3.0.0 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/diff-checkstyle-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/diff-checkstyle-hbase-server.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/whitespace-eol.txt
 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/whitespace-tabs.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/new-findbugs-hbase-server.html
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/patch-unit-root-jdk1.8.0_72.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
 |
| unit test logs |  
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/patch-unit-root-jdk1.7.0_95.txt
 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
 |
| JDK v1.7.0_95  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/testReport/ |
| modules | C: . hbase-server U: . |
| Max memory used | 174MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/479/console |


This message was automatically generated.



> Canary does not accept few client config param from commandline( it should 
> only be present in hbase-site.xml)
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15216
>                 URL: https://issues.apache.org/jira/browse/HBASE-15216
>             Project: HBase
>          Issue Type: Bug
>          Components: canary
>    Affects Versions: 0.98.16
>            Reporter: Vishal Khandelwal
>            Assignee: Vishal Khandelwal
>         Attachments: HBASE-15216.v1.patch
>
>
> At present there are few configs which needs to be present in  hbase-site or 
> default xml for it to work. following are the list.
> hbase.canary.threads.num
> hbase.canary.sink.class
> hbase.client.keytab.file
> hbase.client.kerberos.principal
> Execution in secure expects keytab and princ to be present 
> {noformat}
> 2016-02-05 05:58:44,024 ERROR [main] hbase.AuthUtil - Error while trying to 
> perform the initial login: Running in secure mode, but config doesn't have a 
> keytab
> java.io.IOException: Running in secure mode, but config doesn't have a keytab
>       at org.apache.hadoop.security.SecurityUtil.login(SecurityUtil.java:236)
>       at 
> org.apache.hadoop.hbase.security.User$SecureHadoopUser.login(User.java:392)
>       at org.apache.hadoop.hbase.security.User.login(User.java:259)
>       at 
> org.apache.hadoop.hbase.security.UserProvider.login(UserProvider.java:116)
>       at org.apache.hadoop.hbase.AuthUtil.launchAuthChore(AuthUtil.java:64)
>       at org.apache.hadoop.hbase.tool.Canary.main(Canary.java:1146)
> Exception in thread "main" java.io.IOException: Running in secure mode, but 
> config doesn't have a keytab
>       at org.apache.hadoop.security.SecurityUtil.login(SecurityUtil.java:236)
>       at 
> org.apache.hadoop.hbase.security.User$SecureHadoopUser.login(User.java:392)
>       at org.apache.hadoop.hbase.security.User.login(User.java:259)
>       at 
> org.apache.hadoop.hbase.security.UserProvider.login(UserProvider.java:116)
>       at org.apache.hadoop.hbase.AuthUtil.launchAuthChore(AuthUtil.java:64)
>       at org.apache.hadoop.hbase.tool.Canary.main(Canary.java:1146)
> {noformat}
> {code}
> public static void main(String[] args) throws Exception {
>     final Configuration conf = HBaseConfiguration.create();
>     AuthUtil.launchAuthChore(conf);
>     int numThreads = conf.getInt("hbase.canary.threads.num", MAX_THREADS_NUM);
>     ExecutorService executor = new ScheduledThreadPoolExecutor(numThreads);
>     Class<? extends Sink> sinkClass =
>         conf.getClass("hbase.canary.sink.class", StdOutSink.class, 
> Sink.class);
>     Sink sink = ReflectionUtils.newInstance(sinkClass);
>     int exitCode = ToolRunner.run(conf, new Canary(executor, sink), args);
>     executor.shutdown();
>     System.exit(exitCode);
>   }
> {code}
> In main class these params should be parsed and updated. else for any change 
> to these value hbase-stie.xml needs to be updated 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to