[ 
https://issues.apache.org/jira/browse/HBASE-15233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138907#comment-15138907
 ] 

Jean-Marc Spaggiari commented on HBASE-15233:
---------------------------------------------

I agree. I will try to find time to take a look if we can use that anywhere... 
As you said, might be great. 

For the coding, Rachel assigned this JIRA to her so I believe she is working on 
that. I will let her do and I will search all Bytes.toBytes() usages so see if 
we can use the re-use...

> Bytes.toBytes() methods should allow arrays to be re-used 
> ----------------------------------------------------------
>
>                 Key: HBASE-15233
>                 URL: https://issues.apache.org/jira/browse/HBASE-15233
>             Project: HBase
>          Issue Type: Improvement
>          Components: API
>    Affects Versions: 1.1.3
>            Reporter: Jean-Marc Spaggiari
>            Assignee: Rachel Asher Silver
>            Priority: Minor
>              Labels: beginner
>
> Today we have this:
> {code}
>   public static byte[] toBytes(long val) {
>     byte [] b = new byte[8];
>     for (int i = 7; i > 0; i--) {
>       b[i] = (byte) val;
>       val >>>= 8;
>     }
>     b[0] = (byte) val;
>     return b;
>   }
> {code}
> might be nice to also have this:
> {code}
>   public static byte[] toBytes(long val, byte[] reuse) {
>     for (int i = 7; i > 0; i--) {
>       reuse[i] = (byte) val;
>       val >>>= 8;
>     }
>     reuse[0] = (byte) val;
>     return reuse;
>   }
> {code}
> Same for all the other Bytes.toBytes() methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to