[
https://issues.apache.org/jira/browse/HBASE-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146691#comment-13146691
]
[email protected] commented on HBASE-4554:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2350/#review3121
-----------------------------------------------------------
Thanks for the improved syntax.
src/main/java/org/apache/hadoop/hbase/HConstants.java
<https://reviews.apache.org/r/2350/#comment6937>
We still assume numerals to follow dollar sign. Why is this change needed ?
- Ted
On 2011-11-08 23:00:41, Mingjie Lai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2350/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-08 23:00:41)
bq.
bq.
bq. Review request for hbase and Gary Helmling.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Features:
bq. - Support adding table level coprocessors -- regionobserver and endpoint
-- from shell.
bq. - Support removing table attributes from shell.
bq.
bq. Introduced shell comands:
bq.
bq. hbase> alter 't1', METHOD => 'table_att', \
bq.
'coprocessor'=>'|org.apache.hadoop.hbase.coprocessor.SimpleRegionObserver||'
bq.
bq. coprocessor$1 => 'hdfs:///foo.jar|com.sample.foo|1' will be added to htd.
So that cp framework can load the cp later on.
bq.
bq. hbase> alter 't1', METHOD => 'table_att_unset', NAME => 'MAX_FILESIZE'
bq. hbase> alter 't1', METHOD => 'table_att_unset', NAME => 'coprocessor$1'
bq.
bq.
bq. This addresses bug HBASE-4554.
bq. https://issues.apache.org/jira/browse/HBASE-4554
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/HConstants.java 76278a2
bq. src/main/ruby/hbase/admin.rb 61e04d8
bq. src/main/ruby/shell/commands/alter.rb ee3668d
bq. src/test/ruby/hbase/admin_test.rb df88100
bq.
bq. Diff: https://reviews.apache.org/r/2350/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test passed after applied HBase-4555 patch locally.
bq.
bq.
bq. Thanks,
bq.
bq. Mingjie
bq.
bq.
> Allow set/unset coprocessor table attributes from shell.
> --------------------------------------------------------
>
> Key: HBASE-4554
> URL: https://issues.apache.org/jira/browse/HBASE-4554
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: Mingjie Lai
> Assignee: Mingjie Lai
> Fix For: 0.92.0
>
>
> Table/region level coprocessor -- RegionObserver -- can be configured by
> setting a HTD's attribute which matches Coprocessor$*.
> Current shell -- alter -- cannot support to set/unset a table's arbitrary
> attribute. We need it in order to configure region level coprocessors to a
> table.
> Proposed new shell:
> {code}
> hbase shell > alter 't1', METHOD => 'table_att', COPROCESSOR$1 =>
> 'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|'
> hbase shell > describe 't1'
> {NAME => 't1', COPROCESSOR$1 =>
> 'hdfs://cp/foo.jar|org.apache.hadoop.hbase.sample|1|', MAX_FILESIZE =>
> '134217728', ...}
> hbase shell > alter 't1', METHOD => 'table_att_unset', COPROCESSOR$1
> hbase shell > describe 't1'
> {NAME => 't1', MAX_FILESIZE => '134217728', ...}
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
