[
https://issues.apache.org/jira/browse/HBASE-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146456#comment-15146456
]
Heng Chen commented on HBASE-15266:
-----------------------------------
IMO some monitor threads need to catch throwable.
> add precommit check for "catch Throwable"
> -----------------------------------------
>
> Key: HBASE-15266
> URL: https://issues.apache.org/jira/browse/HBASE-15266
> Project: HBase
> Issue Type: New Feature
> Components: test
> Reporter: Sean Busbey
> Priority: Minor
>
> Catching Throwable is usually incorrect because it gets all of the Error
> derived problems, like ThreadDeath, OutOfMemoryError, VM malfunctions, linker
> problems, etc.
> I was surprised to see findbugs did not flag catching throwable in the
> patches on HBASE-9393. We should add a precommit check that looks expressly
> for it, in our "hbase antipatterns" test plugin.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
