[ 
https://issues.apache.org/jira/browse/HBASE-15285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151648#comment-15151648
 ] 

Sean Busbey commented on HBASE-15285:
-------------------------------------

{code}
+   * @return current value for returnResults
+   */
+  // Used by Increment and Append only.
+  protected boolean isReturnResults() {
+    byte[] v = getAttribute(RETURN_RESULTS);
+    return v == null ? true : Bytes.toBoolean(v);
+  }
+
+  // Used by Increment and Append only.
+  protected Mutation setReturnResults(boolean returnResults) {
+    setAttribute(RETURN_RESULTS, Bytes.toBytes(returnResults));
+    return this;
+  }
+
{code}

Should these methods be annotated IA.Private if we expect them to only be 
usable by Increment and Append?

> Forward-port respect for isReturnResult from HBASE-15095
> --------------------------------------------------------
>
>                 Key: HBASE-15285
>                 URL: https://issues.apache.org/jira/browse/HBASE-15285
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 15095.patch, 15095v2.patch
>
>
> This issue is about forward-porting the bug fix done in HBASE-15095 so we 
> respect the isReturnResult properly in append and increment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to