[
https://issues.apache.org/jira/browse/HBASE-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152410#comment-15152410
]
Jonathan Hsieh edited comment on HBASE-14877 at 2/18/16 3:08 PM:
-----------------------------------------------------------------
Thanks for being patient and sorry for the long gap in feedback.
I'm fairly certain the unit test failures on the last test run are not your
concern.
I did a review pass -- I gave it a spin as as pretty happy. Great docs, esp
good pointers to more resources. I agree with sean on the follow up items.
This would be a great addition to the hbase 1.3 (the next minor version
release sean alluded to).
I basically ran 'mvn install -DskipTests' on hbase with the patch applied, and
then went to a new dir and ran 'mvn archetype:generate -Dfilter=hbase'. a few
questions answered and voila!
I have a few questions -- I'm not am expert on xsl / archetypes, and have some
nits/questions from the poms/java:
hbase-client-project/pom.xml:
- change the java 1.7 compile source/target in the pom? should this be to the
inherited from hbase $\{compileSource\} ? something that the user specifies?
is that a mvn archetype convention?
- nit: should $\{project.version\} be something like $\{hbase.project.version\}
so as not to confuse the 'hbase' being the project or the app on hbase as the
project? or is this a "baked in" convention with archetype definitions?
-- ah after running 'mvn archetype:generate -Dfilter=hbase' i see this gets
replaced with the hbase project version. So we'll just inherit whatever
version hbase has.
(edit: minor formatting fixes)
was (Author: jmhsieh):
Thanks for being patient and sorry for the long gap in feedback.
I'm fairly certain the unit test failures on the last test run are not your
concern.
I did a review pass -- I gave it a spin as as pretty happy. Great docs, esp
good pointers to more resources. I agree with sean on the follow up items.
This would be a great addition to the hbase 1.3 (the next minor version
release sean alluded to).
I basically ran 'mvn install -DskipTests' on hbase with the patch applied, and
then went to a new dir and ran 'mvn archetype:generate -Dfilter=hbase'. a few
questions answered and voila!
I have a few questions -- I'm not am expert on xsl / archetypes, and have some
nits/questions from the poms/java:
hbase-client-project/pom.xml:
- change the java 1.7 compile source/target in the pom? should this be to the
inherited from hbase ${compileSource} ? something that the user specifies? is
that a mvn archetype convention?
- nit: should ${project.version} be something like ${hbase.project.version} so
as not to confuse the 'hbase' being the project or the app on hbase as the
project? or is this a "baked in" convention with archetype definitions?
-- ah after running 'mvn archetype:generate -Dfilter=hbase' i see this gets
replaced with the hbase project version. So we'll just inherit whatever
version hbase has.
> maven archetype: client application
> -----------------------------------
>
> Key: HBASE-14877
> URL: https://issues.apache.org/jira/browse/HBASE-14877
> Project: HBase
> Issue Type: Sub-task
> Components: build, Usability
> Affects Versions: 2.0.0
> Reporter: Nick Dimiduk
> Assignee: Daniel Vimont
> Labels: archetype, beginner, maven
> Attachments: HBASE-14877-v2.patch, HBASE-14877-v3.patch,
> HBASE-14877-v4.patch, HBASE-14877-v5.patch, HBASE-14877.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
