[ 
https://issues.apache.org/jira/browse/HBASE-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147875#comment-13147875
 ] 

Hadoop QA commented on HBASE-4478:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503264/HBASE-4478_1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/224//console

This message is automatically generated.
                
> Improve AssignmentManager.handleRegion so that it can process certain ZK 
> state in the case of RS offline
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4478
>                 URL: https://issues.apache.org/jira/browse/HBASE-4478
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-4478_1.patch
>
>
> Currently AssignmentManager.handleRegion skips processing of ZK event change 
> if the RS is offline. It relies on TimeoutMonitor and ServerShutdownHandler 
> to process RIT.
>       // Verify this is a known server
>       if (!serverManager.isServerOnline(sn) &&
>           !this.master.getServerName().equals(sn)) {
>         LOG.warn("Attempted to handle region transition for server but " +
>           "server is not online: " + Bytes.toString(data.getRegionName()));
>         return;
>       }
> For certain states like OPENED, OPENING, FAILED_OPEN, CLOSED, it can continue 
> the progressing even if the RS is offline.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to