[
https://issues.apache.org/jira/browse/HBASE-15016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156994#comment-15156994
]
Eshcar Hillel commented on HBASE-15016:
---------------------------------------
Looking at the code I'm trying to understand if using the version numbers in
the cells is good enough for updating the wal.
>From what I see now it seems that it is; the solution we suggested before was
>complicated and required getting the wal sequence number from the region, but
>actually the wal sequence id are stamped in the cell in the HRegion method
>processRowsWithLocks(), when performing atomic mutation in the region.
I hope I am not missing anything.
Is this the right way to describe it?
So, for your question [~stack], I will remove the getWalSequenceId() method
from RegionServicesForStores.
HRegion is already implementing 3(!) interfaces. I prefer not to add the 4th
interface and instead use composition for RegionServicesForStores.
But if you insist I can make it an interface.
> StoreServices facility in Region
> --------------------------------
>
> Key: HBASE-15016
> URL: https://issues.apache.org/jira/browse/HBASE-15016
> Project: HBase
> Issue Type: Sub-task
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Attachments: HBASE-15016-V01.patch, HBASE-15016-V02.patch,
> HBASE-15016-V03.patch, HBASE-15016-V04.patch, Regioncounters.pdf,
> suggestion.patch
>
>
> The default implementation of a memstore ensures that between two flushes the
> memstore size increases monotonically. Supporting new memstores that store
> data in different formats (specifically, compressed), or that allows to
> eliminate data redundancies in memory (e.g., via compaction), means that the
> size of the data stored in memory can decrease even between two flushes. This
> requires memstores to have access to facilities that manipulate region
> counters and synchronization.
> This subtasks introduces a new region interface -- StoreServices, through
> which store components can access these facilities.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
