[ https://issues.apache.org/jira/browse/HBASE-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163330#comment-15163330 ]
Elliott Clark commented on HBASE-15319: --------------------------------------- Oops nice catch. Let me clean my mess. > clearJmxCache does not take effect actually > ------------------------------------------- > > Key: HBASE-15319 > URL: https://issues.apache.org/jira/browse/HBASE-15319 > Project: HBase > Issue Type: Bug > Components: metrics > Affects Versions: 1.1.0.1 > Reporter: Hao Lin > Assignee: Elliott Clark > Labels: easyfix > Attachments: HBASE-15319.patch > > > When trying to backport HBASE-14166 to 0.98.6, I find > JmxCacheBuster::clearJmxCache() does no take effect actually. The related > code are listed below: > {code:title=org.apache.hadoop.metrics2.impl.JmxCacheBuster.java|borderStyle=solid} > // fut is initialized to null > private static AtomicReference<ScheduledFuture> fut = new > AtomicReference<>(null); > public static void clearJmxCache() { > // clearJmxCache return directly when fut is null, which is always true. > // the actual intent is 'if (future != null && !future.isDone ...)' ? > ScheduledFuture future = fut.get(); > if ((future == null || (!future.isDone() && > future.getDelay(TimeUnit.MILLISECONDS) > 100))) { > return; > } > ...... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)